jatin510 commented on PR #13040:
URL: https://github.com/apache/datafusion/pull/13040#issuecomment-2434297094
@jcsherin
should i remove this duplicate code from :
datafusion/physical-plan/src/windows/mod.rs:
```
warning: function `get_scalar_value_from_args` is never used
because now we have made copy of these in :
datafusion/functions-window/src/utils.rs
--> datafusion/physical-plan/src/windows/mod.rs:168:4
|
168 | fn get_scalar_value_from_args(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: function `get_unsigned_integer` is never used
--> datafusion/physical-plan/src/windows/mod.rs:199:4
|
199 | fn get_unsigned_integer(value: ScalarValue) -> Result<u64> {
| ^^^^^^^^^^^^^^^^^^^^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
