jonahgao commented on code in PR #13088:
URL: https://github.com/apache/datafusion/pull/13088#discussion_r1814637533
##########
datafusion/sql/src/query.rs:
##########
@@ -88,10 +90,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let empty_schema = DFSchema::empty();
let skip = skip
- .map(|o| self.sql_to_expr(o.value, &empty_schema, &mut
PlannerContext::new()))
+ .map(|o| self.sql_to_expr(o.value, &empty_schema, planner_context))
Review Comment:
We should use the existing `PlannerContext` that includes
`prepare_param_data_types`, instead of creating an empty one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
