comphead commented on code in PR #13081:
URL: https://github.com/apache/datafusion/pull/13081#discussion_r1815341813
##########
datafusion/optimizer/src/utils.rs:
##########
@@ -117,3 +124,165 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) {
debug!("{description}:\n{}\n", plan.display_indent());
trace!("{description}::\n{}\n", plan.display_indent_schema());
}
+
+/// Determine whether a predicate can restrict NULLs. e.g.
+/// `c0 > 8` return true;
+/// `c0 IS NULL` return false.
+pub fn is_restrict_null_predicate<'a>(
+ predicate: Expr,
+ join_cols_of_predicate: impl IntoIterator<Item = &'a Column>,
+) -> Result<bool> {
+ if matches!(predicate, Expr::Column(_)) {
+ return Ok(true);
+ }
+
+ static DUMMY_COL_NAME: &str = "?";
+ let schema = Schema::new(vec![Field::new(DUMMY_COL_NAME, DataType::Null,
true)]);
+ let input_schema = DFSchema::try_from(schema.clone())?;
+ let column = new_null_array(&DataType::Null, 1);
+ let input_batch = RecordBatch::try_new(Arc::new(schema.clone()),
vec![column])?;
+ let execution_props = ExecutionProps::default();
+ let null_column = Column::from_name(DUMMY_COL_NAME);
+
+ let join_cols_to_replace = join_cols_of_predicate
+ .into_iter()
+ .map(|column| (column, &null_column))
+ .collect::<HashMap<_, _>>();
+
+ debug!("predicate: {}", &predicate);
Review Comment:
do we need debug stmts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
