Dandandan commented on PR #13085:
URL: https://github.com/apache/datafusion/pull/13085#issuecomment-2434239371
Hi @mnorfolk03
Thanks for the PR.
I think it will not close the issue. I see you added a number of benchmarks
for *planning* queries with joins, however it seems the linked issue is about
*executing* joins.
I suggest to:
* create a new benchmark (e.g. `join`) that executes against some generated
data
* create a number of join queries (what would be interesting to benchmark at
some point is):
* different join types (inner, left, right, full, etc.)
* different datatype of join keys
* with/without filter
* with/without equijoin condition (hash join/nested loop join)
* compare hash join/sortmergejoin etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
