alamb commented on code in PR #12981:
URL: https://github.com/apache/datafusion/pull/12981#discussion_r1815592498
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -114,17 +114,20 @@ impl DataFilePaths for &String {
}
}
-impl<P> DataFilePaths for Vec<P>
-where
- P: AsRef<str>,
-{
+impl DataFilePaths for Vec<&str> {
Review Comment:
I think the previous implementation would have allowed `Vec<String>` (and
anything else) that implemented `AsRef<str>` as well and after this change
`Vec<String>`
I wonder if we could change the signature to something like
```rust
impl<P> DataFilePaths for Vec<P>
where
P: Into<ListingTableUrl>,
```
Which should still work for anything that allows `AsRef<str>` but also allow
`Vec<ListingTableUrl>` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
