neyama opened a new issue, #13105: URL: https://github.com/apache/datafusion/issues/13105
### Describe the bug # Error summary An error occurs in `parquet_filter` command in the benchmark. # Why does the error occur? While `--prefer_hash_join` option is accepted by [tpch](https://github.com/apache/datafusion/blob/6a3c0b0bce67553a4431b941d13fc995f310bee8/benchmarks/src/tpch/run.rs#L90) command, parquet_filter [does not accept it](https://github.com/apache/datafusion/blob/6a3c0b0bce67553a4431b941d13fc995f310bee8/benchmarks/src/parquet_filter.rs#L70). ### To Reproduce ```console $ cd <path-to>/datafusion/benchmarks $ ./bench.sh run parquet (...snip...) Running parquet filter benchmark... Compiling datafusion-benchmarks v42.1.0 (<path-to>/datafusion/benchmarks) Finished `release` profile [optimized] target(s) in 4m 08s Running `<path-to>/datafusion/target/release/parquet filter --path <path-to>/datafusion/benchmarks/data --prefer_hash_join true --scale-factor 1.0 --iterations 5 -o <path-to>/datafusion/benchmarks/results/main/parquet.json` error: Found argument '--prefer_hash_join' which wasn't expected, or isn't valid in this context USAGE: parquet filter [FLAGS] [OPTIONS] --path <path> For more information try --help $ ./bench.sh run sort (...snip...) Running sort benchmark... Finished `release` profile [optimized] target(s) in 0.43s Running `<path-to>/datafusion/target/release/parquet sort --path <path-to>/datafusion/benchmarks/data --prefer_hash_join true --scale-factor 1.0 --iterations 5 -o <path-to>/datafusion/benchmarks/results/main/sort.json` error: Found argument '--prefer_hash_join' which wasn't expected, or isn't valid in this context USAGE: parquet sort [FLAGS] [OPTIONS] --path <path> For more information try --help ``` ### Expected behavior Both the abovementioned commands complete without any error. ### Additional context ## Does the fix affect README.md? No. As for the explanation on `PREFER_HASH_JOIN=false`, it just addresses `tpch` command, and thus we can keep the explanation as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
