LatrecheYasser commented on code in PR #13108:
URL: https://github.com/apache/datafusion/pull/13108#discussion_r1816616919
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -108,6 +108,7 @@ pub fn name_to_op(name: &str) -> Option<Operator> {
"multiply" => Some(Operator::Multiply),
"divide" => Some(Operator::Divide),
"mod" => Some(Operator::Modulo),
Review Comment:
because `mod` is the same as `modulus` we need to mark it as deprecated
somehow, but how?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
