comphead commented on code in PR #13111:
URL: https://github.com/apache/datafusion/pull/13111#discussion_r1816914748


##########
datafusion/sqllogictest/test_files/sort_merge_join.slt:
##########
@@ -407,214 +407,201 @@ select t1.* from t1 where exists (select 1 from t2 
where t2.a = t1.a and t2.b !=
 statement ok
 set datafusion.execution.batch_size = 10;
 
-# Uncomment when filtered LEFTANTI moved
-#query II
-#select * from (
-#with
-#t1 as (
-#    select 11 a, 12 b),
-#t2 as (
-#    select 11 a, 13 c union all
-#    select 11 a, 14 c
-#    )
-#select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t1.b > t2.c)
-#) order by 1, 2
-#----
-#11 12
-
-# Uncomment when filtered LEFTANTI moved
-#query III
-#select * from (
-#with
-#t1 as (
-#    select 11 a, 12 b, 1 c union all
-#    select 11 a, 13 b, 2 c),
-#t2 as (
-#    select 11 a, 12 b, 3 c union all
-#    select 11 a, 14 b, 4 c
-#    )
-#select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t2.b != t1.b and t1.c > t2.c)
-#) order by 1, 2;
-#----
-#11 12 1
-#11 13 2
-
-# Uncomment when filtered LEFTANTI moved
-#query III
-#select * from (
-#with
-#t1 as (
-#    select 11 a, 12 b, 1 c union all
-#    select 11 a, 13 b, 2 c),
-#t2 as (
-#    select 11 a, 12 b, 3 c where false
-#    )
-#select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t2.b != t1.b and t1.c > t2.c)
-#) order by 1, 2;
-#----
-#11 12 1
-#11 13 2
-
-# Uncomment when filtered LEFTANTI moved
-#query II
-#select * from (
-#with
-#t1 as (
-#    select 11 a, 12 b),
-#t2 as (
-#    select 11 a, 13 c union all
-#    select 11 a, 14 c union all
-#    select 11 a, 15 c
-#    )
-#select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t1.b > t2.c)
-#) order by 1, 2
-#----
-#11 12
-
-# Uncomment when filtered LEFTANTI moved
-#query II
-#select * from (
-#with
-#t1 as (
-#    select 11 a, 12 b),
-#t2 as (
-#    select 11 a, 11 c union all
-#    select 11 a, 14 c union all
-#    select 11 a, 15 c
-#    )
-#select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t1.b > t2.c)
-#) order by 1, 2
-#----
+query II
+select * from (
+with
+t1 as (
+    select 11 a, 12 b),
+t2 as (
+    select 11 a, 13 c union all
+    select 11 a, 14 c
+    )
+select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t1.b > t2.c)
+) order by 1, 2
+----
+11 12
 
-# Uncomment when filtered LEFTANTI moved
-#query II
-#select * from (
-#with
-#t1 as (
-#    select 11 a, 12 b),
-#t2 as (
-#    select 11 a, 12 c union all
-#    select 11 a, 11 c union all
-#    select 11 a, 15 c
-#    )
-#select t1.* from t1 where not exists (select 1 from t2 where t2.a = t1.a and 
t1.b > t2.c)
-#) order by 1, 2
-#----
+query III
+select * from (

Review Comment:
   reenabling tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to