vbarua commented on code in PR #13108:
URL: https://github.com/apache/datafusion/pull/13108#discussion_r1817248874
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -108,6 +108,7 @@ pub fn name_to_op(name: &str) -> Option<Operator> {
"multiply" => Some(Operator::Multiply),
"divide" => Some(Operator::Divide),
"mod" => Some(Operator::Modulo),
Review Comment:
I'm not sure how to produce a deprecation warning for this programatically.
However, we can provide an easy migration path if we also update the
producer code to use `modulus` so we can release a version of DataFusion that
consumes `mod` and `modulus`, and produces only `modulus`. Then the version
after than we remove `mod` and announce it as a breaking change in the release
notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
