alamb commented on code in PR #13103:
URL: https://github.com/apache/datafusion/pull/13103#discussion_r1817774097
##########
datafusion/core/benches/sql_planner.rs:
##########
@@ -235,9 +274,15 @@ fn criterion_benchmark(c: &mut Criterion) {
"q16", "q17", "q18", "q19", "q20", "q21", "q22",
];
+ let benchmarks_path = if PathBuf::from(BENCHMARKS_PATH_1).exists() {
Review Comment:
❤️
##########
datafusion/core/benches/sql_planner.rs:
##########
@@ -258,20 +303,25 @@ fn criterion_benchmark(c: &mut Criterion) {
})
});
- c.bench_function("logical_plan_tpch_all", |b| {
- b.iter(|| {
- for sql in &all_tpch_sql_queries {
- logical_plan(&tpch_ctx, sql)
- }
- })
- });
+ // c.bench_function("logical_plan_tpch_all", |b| {
Review Comment:
maybe we could just delete it entirely?
##########
datafusion/core/benches/sql_planner.rs:
##########
@@ -288,10 +338,53 @@ fn criterion_benchmark(c: &mut Criterion) {
})
});
- c.bench_function("logical_plan_tpcds_all", |b| {
+ // c.bench_function("logical_plan_tpcds_all", |b| {
+ // b.iter(|| {
+ // for sql in &all_tpcds_sql_queries {
+ // logical_plan(&tpcds_ctx, sql)
+ // }
+ // })
+ // });
+
+ // -- clickbench --
+
+ let queries_file =
+
File::open(format!("{benchmarks_path}queries/clickbench/queries.sql")).unwrap();
+ let extended_file =
Review Comment:
I was confused at first what click bench Q48 was (as there are only 42
queries) -- but this now makes sense.
```
physical_plan_clickbench_q48
time: [2.6437 ms 2.6674 ms 2.6943 ms]
Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) high mild
8 (8.00%) high severe
```
It would probably be less confusing if this was called
`physical_plan_clickbench_extended_q5` or whatever to align with the naming of
suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
