Omega359 commented on code in PR #13130:
URL: https://github.com/apache/datafusion/pull/13130#discussion_r1818128858
##########
datafusion/functions/src/datetime/from_unixtime.rs:
##########
@@ -93,12 +124,59 @@ fn get_from_unixtime_doc() -> &'static Documentation {
Documentation::builder()
.with_doc_section(DOC_SECTION_DATETIME)
.with_description("Converts an integer to RFC3339 timestamp format
(`YYYY-MM-DDT00:00:00.000000000Z`). Integers and unsigned integers are
interpreted as nanoseconds since the unix epoch (`1970-01-01T00:00:00Z`) return
the corresponding timestamp.")
- .with_syntax_example("from_unixtime(expression)")
+ .with_syntax_example("from_unixtime(expression, timezone)")
Review Comment:
A SQL example would be a very nice addition to have. The way I typically do
that is to [build the
CLI](https://datafusion.apache.org/user-guide/cli/index.html) with docker, run
it and execute the desired sql in the cli and copy/paste it into the docs here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
