eejbyfeldt commented on code in PR #13134:
URL: https://github.com/apache/datafusion/pull/13134#discussion_r1818159207


##########
datafusion/common/src/join_type.rs:
##########
@@ -113,6 +118,9 @@ pub enum JoinSide {
     Left,
     /// Right side of the join
     Right,
+    /// Neither side of the join, used for Mark joins where the mark column 
does not belong to

Review Comment:
   There is. I started adding both in a single PR but realised that is was more 
changes then I expected, so I did LeftMark first to keep the PR smaller. But 
created an issue for RightMark here: 
https://github.com/apache/datafusion/issues/13138



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to