NoeB commented on PR #1041: URL: https://github.com/apache/datafusion-comet/pull/1041#issuecomment-2440640745
Interesting, I just reran the bench and I get the same improvements as before. Should I compare the library implementation with the DataFusion custom one to see if there is a difference? Shall I add the following command to the docs: `cd native && cargo clippy --color=never --all-targets --workspace -- -D warnings` in the [( Submitting a PR section)](https://datafusion.apache.org/comet/contributor-guide/development.html#submitting-a-pull-request)? I think it would have saved me several CI runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
