alamb commented on issue #13124: URL: https://github.com/apache/datafusion/issues/13124#issuecomment-2441693366
> Just curious -- if we knew about this prior to merging #12864, would we still merge it? I think we would have had the same discussion we are having now -- is the benefit gained from https://github.com/apache/datafusion/pull/12864 worth the potential regression in a feature that maybe worked by accident. I also think it is reasonable to have different opinions on the cost/benefit analysis, for what it is worth The conversation would have been different if there had been tests showing someone was relying on the old behavior In such cases I normally default to going with the person contributing the change / putting in the effort to maintain it. If someone else was relying on the feature they'll tell us with a PR / issue in the future I do wish we had infinite capacity to make the software perfect, but given we are constrained with resources I think we need to be pragmatic and align the contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
