vbarua commented on PR #13118: URL: https://github.com/apache/datafusion/pull/13118#issuecomment-2442869215
> What would be the point of having both UNSPECIFIED and NO_OUTPUT in that case? My understanding is that the use of UNSPECIFIED as the first value in the Substrait enums comes from this Protobuf developer recommendation https://protobuf.dev/programming-guides/dos-donts/#unspecified-enum It's not intended to mean > "we don't care, plan doesn't depend on it". though I can understand why it would seem like that. In Substrait, UNSPECIFIED effectively means unset by the producer and the spec tries to define default behaviours in those cases. I'm interpreting the line > Common default is NO_OUTPUT where we return nothing. from [substrait.io/relations/logical_relations#write-operator](https://substrait.io/relations/logical_relations/#write-operator) as indicated that the default behaviour is to not return any output, but tbh that could/should be made clearer if that's the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
