alamb commented on code in PR #13172: URL: https://github.com/apache/datafusion/pull/13172#discussion_r1821448563
########## docs/source/contributor-guide/howtos.md: ########## @@ -64,6 +66,8 @@ Below is a checklist of what you need to do to add a new aggregate function to D - In [sqllogictest/test_files], add new `sqllogictest` integration tests where the function is called through SQL against well known data and returns the expected result. - Documentation for `sqllogictest` [here](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/README.md) - Add SQL reference documentation [here](https://github.com/apache/datafusion/blob/main/docs/source/user-guide/sql/aggregate_functions.md) + - An example of this being done can be seen [here] (https://github.com/apache/datafusion/pull/12775) Review Comment: ```suggestion - An example of this being done can be seen [here](https://github.com/apache/datafusion/pull/12775) ``` ########## docs/source/contributor-guide/howtos.md: ########## @@ -45,6 +45,8 @@ Below is a checklist of what you need to do to add a new scalar function to Data - In [sqllogictest/test_files], add new `sqllogictest` integration tests where the function is called through SQL against well known data and returns the expected result. - Documentation for `sqllogictest` [here](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/README.md) - Add SQL reference documentation [here](https://github.com/apache/datafusion/blob/main/docs/source/user-guide/sql/scalar_functions.md) + - An example of this being done can be seen [here] (https://github.com/apache/datafusion/pull/12775) Review Comment: ```suggestion - An example of this being done can be seen [here](https://github.com/apache/datafusion/pull/12775) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
