comphead commented on code in PR #13134:
URL: https://github.com/apache/datafusion/pull/13134#discussion_r1821449526
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -784,6 +790,29 @@ fn get_corrected_filter_mask(
corrected_mask.extend(vec![Some(false); null_matched]);
Some(corrected_mask.finish())
}
+ JoinType::LeftMark => {
+ for i in 0..row_indices_length {
+ let last_index =
+ last_index_for_row(i, row_indices, batch_ids,
row_indices_length);
+ if filter_mask.value(i) && !seen_true {
Review Comment:
Oh I see now, chatGPT was helpful
| Join Type | Output Columns | Rows Returned
|
|------------------|--------------------------------------|----------------------------------------------|
| **Left Semi Join** | Columns from the left table only | Only rows with
matches in the right table |
| **Left Mark Join** | Columns from the left table + match flag | All rows
from the left table |
I think it would be good to document somewhere as well as saying its not
naturally supported by SQL.
In this case how the user gonna use it? Example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
