alamb commented on PR #13082: URL: https://github.com/apache/datafusion/pull/13082#issuecomment-2445220630
> > Is it possible to add a test for this change? > > Do we have a test collection for this interface? Because just adding a unit test within this module sounds like "you just test that it is forwarded at all", which IMHO has limited value. I found https://github.com/apache/datafusion/blob/9355f4a5c7cb99df318ea98316cafc9b0494316f/datafusion/physical-expr/src/expressions/negative.rs#L226-L225 I'll add a test to this PR similarly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
