findepi commented on code in PR #13170:
URL: https://github.com/apache/datafusion/pull/13170#discussion_r1821470775
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -191,51 +183,47 @@ async fn test_full_join_1k_filtered() {
JoinType::Full,
Some(Box::new(col_lt_col_filter)),
)
- .run_test(&[JoinTestType::NljHj], false)
+ .run_test(&[NljHj], false)
.await
}
#[tokio::test]
-#[allow(unused_qualifications)]
async fn test_semi_join_1k() {
JoinFuzzTestCase::new(
make_staggered_batches(1000),
make_staggered_batches(1000),
JoinType::LeftSemi,
None,
)
- .run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], false)
+ .run_test(&[JoinTestType::HjSmj, NljHj], false)
Review Comment:
Why would we want to import the left but not the right?
Maybe rather than removing the now-redundant `JoinTestType::`
qualifications, we could remove `use` statements ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
