goldmedal commented on code in PR #12990:
URL: https://github.com/apache/datafusion/pull/12990#discussion_r1822494164
##########
datafusion/core/tests/fuzz_cases/aggregation_fuzzer/fuzzer.rs:
##########
@@ -417,8 +435,7 @@ impl QueryBuilder {
mut self,
group_by: impl IntoIterator<Item = &'a str>,
) -> Self {
- let group_by = group_by.into_iter().map(String::from);
- self.group_by_columns.extend(group_by);
+ self.group_by_columns =
group_by.into_iter().map(String::from).collect();
Review Comment:
I noticed you changed the behavior from extending to replacing. However, the
behaviors are still extending or pushing, e.g.,
`with_distinct_aggregate_function` or `with_aggregate_arguments`. I think all
the behaviors are better to be aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
