andygrove commented on code in PR #1039:
URL: https://github.com/apache/datafusion-comet/pull/1039#discussion_r1824474124
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -769,11 +769,7 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
val numBitsExpr = exprToProto(numBits, inputs, binding)
val dataType = serializeDataType(bloom_filter.dataType)
- // TODO: Support more types
- // https://github.com/apache/datafusion-comet/issues/1023
if (childExpr.isDefined &&
- child.dataType
- .isInstanceOf[LongType] &&
Review Comment:
Rather than remove the type check, should we update the check for the
supported types, or are we confident that we support all the types and that
future versions of Spark won't support additional types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
