findepi commented on issue #13190: URL: https://github.com/apache/datafusion/issues/13190#issuecomment-2450197212
Would that mean that constant folding (like this issue) requires the relaxed comparison parameter to be set? it would be the default behavior then, right? > Probably what we can do is implement `Eq` with full check on the _code level_, i agree that `Eq` should do the full check. Value-based classes should be compared by value in general. For logical/physical schema comparison and nulls, we can choose not to call `Eq`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
