viirya commented on code in PR #1047:
URL: https://github.com/apache/datafusion-comet/pull/1047#discussion_r1825070845
##########
native/core/src/parquet/mod.rs:
##########
@@ -52,7 +52,6 @@ const STR_CLASS_NAME: &str = "java/lang/String";
/// Parquet read context maintained across multiple JNI calls.
struct Context {
pub column_reader: ColumnReader,
- pub arrays: Option<(Arc<FFI_ArrowArray>, Arc<FFI_ArrowSchema>)>,
Review Comment:
This refactoring simplifies the context and the logic. We don't need to keep
the array and schema pointers in the producer side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
