alamb commented on PR #13203: URL: https://github.com/apache/datafusion/pull/13203#issuecomment-2452122993
> IMO we should make fields public instead. See [#13202 (comment)](https://github.com/apache/datafusion/issues/13202#issuecomment-2450181549) I am not sure making the fields `pub` really solves my usecase -- namely that I have a `&SortExec` (ref to a SortExec that is really in an `Arc<..>`) and I want to make a modified copy of it. Even if the fields are `pub` I still couldn't change them. I don't have a strong preference one way or the other over pub fields (or `mut` accessors like `set_preserve_partitions()`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
