alamb opened a new issue, #13220: URL: https://github.com/apache/datafusion/issues/13220
### Is your feature request related to a problem or challenge? Now that `LexOrdering` and `LexRequirement` are actual structs thanks to @ngli-me and @berkaysynnada on https://github.com/apache/datafusion/pull/13146, we can refer to their references as `&LexOrdering` and `&LexRequirement` directly rather than going through a type alias. For example ```rust ///`LexOrderingRef` is an alias for the type &`[PhysicalSortExpr]`, which represents /// a reference to a lexicographical ordering. pub type LexOrderingRef<'a> = &'a [PhysicalSortExpr]; ``` This is significantly less confusing than the current situation where we have both `&LexOrdering` and `LexOrderingRef` and `&LexRequirement` and `LexRequirementRef` ### Describe the solution you'd like I would like to 1. Deprecate `LexOrderingRef` and `LexRequirementRef` 2. Update all references to use `&LexOrdering` and `&LexRequirement` directly ### Describe alternatives you've considered Basically make this change: ```rust ///`LexOrderingRef` is an alias for the type &`[PhysicalSortExpr]`, which represents /// a reference to a lexicographical ordering. #[deprecated(since = "43.0.0", note = "use &LexOrdering instead")] pub type LexOrderingRef<'a> = &'a [PhysicalSortExpr]; ``` And the similar change to `LexRequirementRef` and then fix all the clippy errors :) ### Additional context I have a WIP here https://github.com/apache/datafusion/pull/13205 that someone could pull from -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
