alamb commented on code in PR #13222:
URL: https://github.com/apache/datafusion/pull/13222#discussion_r1826230178
##########
datafusion/core/src/physical_optimizer/sort_pushdown.rs:
##########
@@ -243,8 +240,7 @@ fn pushdown_requirement_to_children(
smj.schema().fields.len() -
smj.right().schema().fields.len();
let new_right_required =
shift_right_required(parent_required, right_offset)?;
- let new_right_required_expr =
- PhysicalSortRequirement::to_sort_exprs(new_right_required);
+ let new_right_required_expr =
LexOrdering::from(new_right_required);
Review Comment:
I think this structure makes it much clearer what is going on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
