alamb commented on code in PR #13187:
URL: https://github.com/apache/datafusion/pull/13187#discussion_r1826258778
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -371,7 +371,12 @@ impl ExecutionPlan for FilterExec {
/// The output statistics of a filtering operation can be estimated if the
/// predicate's selectivity value can be determined for the incoming data.
fn statistics(&self) -> Result<Statistics> {
- Self::statistics_helper(&self.input, self.predicate(),
self.default_selectivity)
+ let stats = Self::statistics_helper(
Review Comment:
I agree the statistics calculation should be more sophisticated and I filed
https://github.com/apache/datafusion/issues/13224 to track the idea
However, I am worried about trying to change how the statistics calculations
work in this PR (I outlined some challenges I see in
https://github.com/apache/datafusion/issues/13224)
Thus, I would like avoid doing a more substantial change in this PR (which
fixes a functional bug) and we can sort out how to improve the statistics
calculations as a subsequent PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
