iffyio commented on PR #1482: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1482#issuecomment-2452866395
Ah yeah by both styles I mean that, today when displaying sql, the parser _always_ uses upper case e.g. `FLOAT64`. While the changes in this PR updates that behavior such that for some types it now uses camel case `Float64` - which I expect will break a lot of tests (and worse may be undesirable for other dialects). The changes aren't specific to clickhouse, Float64 for example is used by BigQuery. I agree that it will be quite invasive to make this behavior configurable. On the other hand, I fear that using camel case for some types vs upper case for others will be quite haphazard (especially if Clickhouse isn't alone with this requirement). Currently I'm not sure what a good way to approach this issue is actually :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
