drauschenbach commented on code in PR #13227:
URL: https://github.com/apache/datafusion/pull/13227#discussion_r1826582516
##########
datafusion/physical-plan/src/joins/cross_join.rs:
##########
@@ -47,7 +47,15 @@ use async_trait::async_trait;
use futures::{ready, Stream, StreamExt, TryStreamExt};
/// Data of the left side
-type JoinLeftData = (RecordBatch, MemoryReservation);
+#[derive(Debug)]
+struct JoinLeftData {
+ /// Single RecordBatch with all rows from the left side
+ merged_batch: RecordBatch,
+ /// Track memory reservation for merged_batch. Relies on drop
+ /// semantics to release reservation when JoinLeftData is dropped.
+ #[allow(dead_code)]
+ reservation: MemoryReservation,
Review Comment:
Pretty or not, `_reservation` is the language-appropriate idiom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
