comphead commented on code in PR #13246:
URL: https://github.com/apache/datafusion/pull/13246#discussion_r1828014449
##########
datafusion/expr/src/udf.rs:
##########
@@ -489,19 +493,40 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
/// Invoke the function with `args` and the number of rows,
/// returning the appropriate result.
+ ///
+ /// The function will be invoked with the slice of [`ColumnarValue`]
+ /// (either scalar or array).
+ ///
+ /// # Performance
+ ///
+ /// For the best performance, the implementations of `invoke` should handle
Review Comment:
should we refer to `invoke` method anymore as its deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
