findepi commented on code in PR #13061:
URL: https://github.com/apache/datafusion/pull/13061#discussion_r1828027865
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1470,19 +1470,31 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S> {
}) => Transformed::yes(simplify_regex_expr(left, op, right)?),
// Rules for Like
- Expr::Like(Like {
- expr,
- pattern,
- negated,
- escape_char: _,
- case_insensitive: _,
- }) if !is_null(&expr)
- && matches!(
- pattern.as_ref(),
- Expr::Literal(ScalarValue::Utf8(Some(pattern_str))) if
pattern_str == "%"
- ) =>
- {
- Transformed::yes(lit(!negated))
+ Expr::Like(ref like_expr) => {
+ if let Expr::Literal(ScalarValue::Utf8(Some(pattern_str))) =
+ like_expr.pattern.as_ref()
+ {
+ if !is_null(&like_expr.expr) && pattern_str == "%" {
+ Transformed::yes(lit(!like_expr.negated))
+ } else if !pattern_str.contains(['%', '_'].as_ref()) {
+ // If the pattern does not contain any wildcards, we
can simplify the like expression to an equality expression
+ if like_expr.escape_char.is_some() {
Review Comment:
nit: can this condition be checked on the same line with
`!pattern_str.contains(['%', '_']`
it would reduce code branching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
