alamb commented on code in PR #13250:
URL: https://github.com/apache/datafusion/pull/13250#discussion_r1828271366
##########
datafusion/common/src/config.rs:
##########
@@ -1773,7 +1773,7 @@ config_namespace! {
/// Options controlling JSON format
pub struct JsonOptions {
pub compression: CompressionTypeVariant, default =
CompressionTypeVariant::UNCOMPRESSED
- pub schema_infer_max_rec: usize, default = 100
+ pub schema_infer_max_rec: Option<usize>, default = None
Review Comment:
If we make this change to be `Option` then it is inconsistent with the JSON
options:
https://github.com/apache/datafusion/blob/2d7892b6060793e721ce1d66242f485656e0430a/datafusion/common/src/config.rs#L1775-L1776
I think it would be best to keep the two options consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
