parthchandra commented on PR #1034: URL: https://github.com/apache/datafusion-comet/pull/1034#issuecomment-2455871116
I considered going column then rows. This gets a little complicated with variable length as now we have to keep the offset for each row at which the variable length part can be written. This part of the code is no longer correct with variable length types - ``` let row_size = SparkUnsafeRow::get_row_bitset_width(schema.len()) + 8 * num_cols; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
