alamb commented on code in PR #13183: URL: https://github.com/apache/datafusion/pull/13183#discussion_r1829691619
########## datafusion/ffi/README.md: ########## @@ -19,63 +19,94 @@ # `datafusion-ffi`: Apache DataFusion Foreign Function Interface -This crate contains code to allow interoperability of Apache [DataFusion] -with functions from other languages using a stable interface. +This crate contains code to allow interoperability of Apache [DataFusion] with +functions from other libraries and/or [DataFusion] versions using a stable +interface. + +One of the limitations of the Rust programming language is that there is no Review Comment: 👍 ########## datafusion-examples/examples/ffi/ffi_module_interface/src/lib.rs: ########## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use abi_stable::{ + declare_root_module_statics, + library::{LibraryError, RootModule}, + package_version_strings, + sabi_types::VersionStrings, + StableAbi, +}; +use datafusion_ffi::table_provider::FFI_TableProvider; + +#[repr(C)] +#[derive(StableAbi)] +#[sabi(kind(Prefix(prefix_ref = TableProviderModuleRef)))] Review Comment: I don't fully understand the need for this interface module. Couldn't the caller program simple use `construct_simple_table_provider` directly? (It would have to know the name of the entry point of course which is less general than what you have here) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
