jonathanc-n commented on PR #13252:
URL: https://github.com/apache/datafusion/pull/13252#issuecomment-2458236706
@eejbyfeldt I implemented the swapping, would be nice to see if I did that
correctly.
I made a change to `adjust_indices_by_join_type` and combined the logic for
the right join and rightmark join for indices:
```
JoinType::Right | JoinType::RightMark => {
// combine the matched and unmatched right result together
append_right_indices(
left_indices,
right_indices,
adjust_range,
preserve_order_for_right,
)
}```
`join_right_mark` test had previously not given any results and is now
giving a table with values. However, it is marking all the values as true and I
cannot seem to track the issue down. Would you be able to look into this?
Instead of this:
```
"+----+----+----+-------+",
"| a2 | b1 | c2 | mark |",
"+----+----+----+-------+",
"| 10 | 4 | 70 | true |",
"| 20 | 5 | 80 | true |",
"| 30 | 6 | 90 | false |",
"+----+----+----+-------+",
it is giving this:
"+----+----+----+-------+",
"| a2 | b1 | c2 | mark |",
"+----+----+----+-------+",
"| 10 | 4 | 70 | true |",
"| 20 | 5 | 80 | true |",
"| 30 | 6 | 90 | true |",
"+----+----+----+-------+",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
