sgrebnov commented on code in PR #13267:
URL: https://github.com/apache/datafusion/pull/13267#discussion_r1830122206
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -882,6 +882,7 @@ fn test_table_scan_pushdown() -> Result<()> {
let query_from_table_scan_with_projection = LogicalPlanBuilder::from(
table_scan(Some("t1"), &schema, Some(vec![0, 1]))?.build()?,
)
+ .project(vec![col("id"), col("age")])?
.project(vec![wildcard()])?
Review Comment:
Can this actually be a real plan with a wildcard projection and a TableScan
that includes only two columns? I would expect them to match. If this is a real
use case I will improve logic above (check for parent projection is a wildcard
or does not match). Running all TPC-H and TPC-DS queries I've not found query
where it was the case.
https://github.com/apache/datafusion/pull/13267/files#r1830100022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
