lovasoa commented on code in PR #1498:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1498#discussion_r1831035224
##########
src/parser/mod.rs:
##########
@@ -10000,7 +10000,7 @@ impl<'a> Parser<'a> {
table_with_joins: Box::new(table_and_joins),
alias,
})
- } else if dialect_of!(self is SnowflakeDialect | GenericDialect) {
+ } else if dialect_of!(self is SnowflakeDialect | GenericDialect |
MsSqlDialect) {
Review Comment:
You may want to update the comments below too.
##########
src/ast/query.rs:
##########
@@ -2346,6 +2386,40 @@ impl fmt::Display for JsonTableColumnErrorHandling {
}
}
+/// A single column definition in MSSQL's `OPENJSON WITH` clause.
+///
+/// ```sql
+/// colName type [ column_path ] [ AS JSON ]
+/// ```
+///
+/// Reference:
<https://learn.microsoft.com/en-us/sql/t-sql/functions/openjson-transact-sql?view=sql-server-ver16#syntax>
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+pub struct OpenJsonTableColumn {
+ /// The name of the column to be extracted.
+ pub name: Ident,
+ /// The type of the column to be extracted.
+ pub r#type: DataType,
+ /// The path to the column to be extracted. Must be a literal string.
+ pub path: Option<Value>,
Review Comment:
If this needs to be a string, then maybe store an Option<String> ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
