getChan commented on code in PR #13295:
URL: https://github.com/apache/datafusion/pull/13295#discussion_r1833010040
##########
datafusion/physical-expr-common/src/binary_map.rs:
##########
@@ -349,10 +349,14 @@ where
let batch_hashes = &mut self.hashes_buffer;
batch_hashes.clear();
batch_hashes.resize(values.len(), 0);
- create_hashes(&[values.clone()], &self.random_state, batch_hashes)
- // hash is supported for all types and create_hashes only
- // returns errors for unsupported types
- .unwrap();
+ create_hashes(
+ &[Arc::<dyn Array>::clone(values)],
Review Comment:
maybe not. removed explicit type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
