SemyonSinchenko commented on PR #1073: URL: https://github.com/apache/datafusion-comet/pull/1073#issuecomment-2468325238
@andygrove Sorry for tagging but I have questions about the ticket (`array_insert`). 1. `array_insert` was added in spark 3.4, so all the 3.3.x tests are obviously failed. I checked and it looks like the EoL for 3.3 is about the end of 2024. Technically I think I can try to workaround tests in 3.3.x by reflection API, my question is mostly should I do it due to soon EoL of the 3.3.x? 2. `array_insert` is not supported in DataFusion. I made an implementation (and it looks like it works, except negative indices and corner cases). Is the `list.rs` a good place for it? Or should I move my code somewhere else? 3. Spark [does not support anything except](https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L4736-L4760) `Int32` for position argument, is it OK if I will support only int32 too? In theory, other types can be supported too, but I'm still trying to realize how to achieve it and it may become complex... Thanks in advance! That is my first serious attempt to contribute to the project, so sorry If I'm annoying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
