viirya commented on code in PR #1076:
URL: https://github.com/apache/datafusion-comet/pull/1076#discussion_r1837328909


##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -77,6 +77,15 @@ object CometConf extends ShimCometConf {
     .booleanConf
     .createWithDefault(true)
 
+  val COMET_FULL_NATIVE_SCAN_ENABLED: ConfigEntry[Boolean] = conf(
+    "spark.comet.native.scan.enabled")
+    .doc(
+      "Whether to enable the fully native scan. When this is turned on, Spark 
will use Comet to " +
+        "read supported data sources (currently only Parquet is supported 
natively)." +
+        " By default, this config is true.")
+    .booleanConf
+    .createWithDefault(true)

Review Comment:
   No, I meant I tried to do similar native scan change into this branch. I was 
trying to enable DataFusion native Parquet scan yesterday. I found this branch 
this morning so tried to apply initial change onto this branch.
   
   I will see if any difference can be merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to