iffyio commented on code in PR #1507:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1507#discussion_r1838542732
##########
src/parser/mod.rs:
##########
@@ -11096,6 +11096,19 @@ impl<'a> Parser<'a> {
arg,
operator: FunctionArgOperator::Assignment,
})
+ } else if dialect_of!(self is MsSqlDialect) {
+ // FUNC(<expr> : <expr>)
+ let name = self.parse_wildcard_expr()?;
+ if self.consume_token(&Token::Colon) {
+ let arg = self.parse_expr()?.into();
+ Ok(FunctionArg::Named {
+ name,
+ arg,
+ operator: FunctionArgOperator::Colon,
+ })
Review Comment:
Yeah I think that sounds good!
##########
src/parser/mod.rs:
##########
@@ -11141,19 +11154,34 @@ impl<'a> Parser<'a> {
/// FIRST_VALUE(x IGNORE NULL);
/// ```
fn parse_function_argument_list(&mut self) -> Result<FunctionArgumentList,
ParserError> {
+ let mut clauses = vec![];
+
+ if dialect_of!(self is MsSqlDialect) {
+ // JSON_ARRAY(NULL ON NULL)
+ if self.parse_keywords(&[Keyword::NULL, Keyword::ON,
Keyword::NULL]) {
+ clauses.push(FunctionArgumentClause::JsonNullClause(
+ JsonNullClause::NullOnNull,
+ ));
+ }
+ // JSON_ARRAY(ABSENT ON NULL)
Review Comment:
Oh I see, yeah checking early makes sense! We can move the parsing to a new
method so that it can be reused in both places i imagine in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
