alamb commented on code in PR #13346:
URL: https://github.com/apache/datafusion/pull/13346#discussion_r1840312633
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -282,15 +293,34 @@ pub fn simplify_concat(args: Vec<Expr>) ->
Result<ExprSimplifyResult> {
let mut new_args = Vec::with_capacity(args.len());
let mut contiguous_scalar = "".to_string();
+ let mut merged_type = DataType::Utf8;
Review Comment:
Rather than re-computing the merged type, could you just call
https://github.com/apache/datafusion/blob/6686e034dd1008fc7303c482cf664402eca25d67/datafusion/functions/src/string/concat.rs#L70-L71
And use that type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
