alamb opened a new pull request, #13393: URL: https://github.com/apache/datafusion/pull/13393
Draft as it builds on https://github.com/apache/datafusion/pull/13201 ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes https://github.com/apache/datafusion/issues/8709 :tada:!!! - Follow on https://github.com/apache/datafusion/pull/13201 ## Rationale for this change @buraksen and @jcsherin ported the last window function over, so now we can remove the old BuiltInWindowFunction code This was so tempting a cleanup that I had to give it a try (and I wanted to do some coding) ## What changes are included in this PR? Changes: 1. Remove `BuiltInWindowFunction` 2. Remove `BuiltInWindowFunctionDefinition::BuiltInWindowFunction` 3. Remove Protobuf definitions 4. Update code to compile ## Are these changes tested? Yes, by existing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
