comphead commented on code in PR #13377:
URL: https://github.com/apache/datafusion/pull/13377#discussion_r1840730136
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -265,14 +266,18 @@ async fn sort_spill_reservation() {
// This test case shows how sort_spill_reservation works by
// purposely sorting data that requires non trivial memory to
// sort/merge.
+
+ // Merge operation needs extra memory to do row conversion, so make the
+ // memory limit larger.
+ let mem_limit = partition_size * 2;
Review Comment:
This can be introduced as DataFusion parameter so the user can configure the
memory allocation realm. I got some feeling the mem is data dependent,
depending on datatypes/data being processed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
