jcsherin commented on issue #13401: URL: https://github.com/apache/datafusion/issues/13401#issuecomment-2477135304
> But despite the name, BuiltInWindowExpr actually now wraps a UDWF. Yes, this is indeed the case. None of the user-defined window functions are currently serialized. We missed this during conversion. I expect serialization of user-defined window functions to be simpler compared to built-in window functions. In built-in window serialization depended on the internals. You can see that in the serialization code here: https://github.com/apache/datafusion/blob/6a4a280e3cf70fe5f1a1cfe7c2de13e4c39f89bb/datafusion/proto/src/physical_plan/to_proto.rs#L130-L148 We need to also extend `PhysicalExtensionCodec` for user-defined window function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
