andygrove commented on code in PR #1086:
URL: https://github.com/apache/datafusion-comet/pull/1086#discussion_r1843086541
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -895,6 +895,18 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("cast between decimals with different precision and scale") {
Review Comment:
It's great to see that some basic tests now pass. I assume there must have
been improvements in DataFusion since we started this project.
I'd like to see the tests cover more scenarios, such as:
- Casting from smaller scale to larger scale e.g. (10, 1) to (10, 4)
- Tests for edge cases such as negative scale and zero scale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
