jayzhan211 commented on code in PR #13382:
URL: https://github.com/apache/datafusion/pull/13382#discussion_r1843497733
##########
datafusion/sqllogictest/test_files/string/string_view.slt:
##########
@@ -935,12 +935,19 @@ logical_plan
01)Projection: to_timestamp(test.column1_utf8view, Utf8("a,b,c,d")) AS c
02)--TableScan: test projection=[column1_utf8view]
-## Ensure no casts for nullif
+## Ensure no casts for NVL
query TT
+EXPLAIN SELECT NVL(column1_utf8view, 'a') as c2 FROM test;
+----
+logical_plan
+01)Projection: nvl(test.column1_utf8view, Utf8View("a")) AS c2
+02)--TableScan: test projection=[column1_utf8view]
+
+## Ensure no casts for nullif
+query error DataFusion error: SQL error: ParserError\("Expected: an SQL
statement, found: logical_plan"\)
Review Comment:
I recheck this and found it is error, why is that?
##########
datafusion/sqllogictest/test_files/string/string_view.slt:
##########
@@ -935,12 +935,19 @@ logical_plan
01)Projection: to_timestamp(test.column1_utf8view, Utf8("a,b,c,d")) AS c
02)--TableScan: test projection=[column1_utf8view]
-## Ensure no casts for nullif
+## Ensure no casts for NVL
query TT
+EXPLAIN SELECT NVL(column1_utf8view, 'a') as c2 FROM test;
+----
+logical_plan
+01)Projection: nvl(test.column1_utf8view, Utf8View("a")) AS c2
+02)--TableScan: test projection=[column1_utf8view]
+
+## Ensure no casts for nullif
+query error DataFusion error: SQL error: ParserError\("Expected: an SQL
statement, found: logical_plan"\)
Review Comment:
I recheck this and found this is error, why is that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
