findepi commented on PR #13388: URL: https://github.com/apache/datafusion/pull/13388#issuecomment-2480672367
This change has two aspects 1. fixing hash joins on types that are not hashable, but can_hash considered them hashable. This is eg List of something unhashable. I couldn't write a test for this, since types such as listview or ree hit other problems. 2. unblocking hash joins on types that are actually hashable, but can_hash considered them not hashable. This is not as edge-case'y, for example `binary` is hashable, but we didn't use hash joins when joining on binary. I added a plan test for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
