jayzhan211 commented on code in PR #13466: URL: https://github.com/apache/datafusion/pull/13466#discussion_r1846514032
########## datafusion/sqllogictest/test_files/expr.slt: ########## @@ -1487,32 +1487,32 @@ SELECT extract(epoch from arrow_cast('1969-12-31', 'Date64')) # test_extract_interval -query R +query I SELECT extract(year from arrow_cast('10 years', 'Interval(YearMonth)')) ---- 10 -query R +query I Review Comment: Since `I` is for integer and we don't need to make sure it is exactly i32 or i64 so I think that is fine. If we want to differentiate type like utf8 or utf8View then we need `arrow_typeof` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org