himadripal commented on code in PR #1086:
URL: https://github.com/apache/datafusion-comet/pull/1086#discussion_r1849146946
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -231,11 +231,9 @@ abstract class CometTestBase
df: => DataFrame): (Option[Throwable], Option[Throwable]) = {
var expected: Option[Throwable] = None
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
- val dfSpark = Dataset.ofRows(spark, df.logicalPlan)
- expected = Try(dfSpark.collect()).failed.toOption
+ expected = Try(Dataset.ofRows(spark,
df.logicalPlan).collect()).failed.toOption
Review Comment:
Earlier only df.collect() part was inside the Try, I also included
df.logicalPlan - this includes any exception during parsing, in this example,
it was throwing parsing error for this
```sql
select a, cast(a as DECIMAL(10,-4)) from t order by a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
